[develop]: Updates for building and running SRW on MacOS platform #1171
+103
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
community test configuration example for MacOS
natalie-perlin
requested review from
mkavulich,
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
EdwardSnyder-NOAA,
MichaelLueken,
rickgrubin-noaa,
BruceKropp-Raytheon and
BenKoziol-NOAA
as code owners
gspetro-NOAA
requested changes
Dec 30, 2024
There was a problem hiding this comment.
I know this is in draft form, so perhaps you were already planning to do this, but the Google docs version of the documentation needs to be added to the authoritative SRW documentation (particularly the RunSRW chapter) where it differs from what's already there. Normally, I'd leave the change request till the PR is fully open, but since it already has an approval, I wanted to make sure that doesn't get missed. :)
RatkoVasic-NOAA
approved these changes
Dec 30, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Updated scripts and modulefiles to ensure SRW could be built and run on MacOS.
Building could be done using devbuild.sh script.
Running MacOS is done using standalone scripts located in ./ush/wrappers/*.
Building the UFS weather model code includes use of CXX linker instead of Fortran linker, the change of a CMakeLists.txt file for the WM is done in devbuild.sh.
Software packages mostly correspond spack-stack-1.8.0. Directions for building the sofware stack and running the SRW are included below in two separate links to documents (working copies).
Running SRW on MacOS:
https://docs.google.com/document/d/1ADfLi4Yaa25IXz7ZhGxoRlDcmvATIlRD0KI9Se-ZJ3c/edit?usp=sharing
Building spack-stack on MacOS for UFS-WM and SRW:
https://docs.google.com/document/d/1Z0L7eujZGtyeZRzcgguyZPsZpkwb2Om7UhFqQPVtxnE/edit?usp=sharing
Type of change
TESTS CONDUCTED:
Tests are conducted on three different MacOS platforms
-->
DEPENDENCIES:
A PR to the UFS-WM has been submitted: ufs-community/ufs-weather-model#2551
Current version of devbuild.sh assumes no changes to weather-model CMakeFiles.txt has been made.
DOCUMENTATION:
Documentation may need to be updated to reflect a new option to use devbuild.sh script for the build on MacOS platform.
ISSUE:
Addresses the issue mentioned in #1168
Documentation lists only CMake approach to be used on MacOS. It creates errors on MacOS, as well as requires additional steps (not documented) required for running the SRW. Adapted devbuild.sh script allows SRW to be built on MacOS.
Addressed the issue of running UFS WM on MacOS mentioned in ufs-community/ufs-weather-model#2371
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):